Open
Conversation
…it wasn't previously...
bump deps, sort, remove unused & use proper feature flags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I went to use the gaussian with rayon and noticed it was horribly busted.
Whilst I was in there:
safe_get() -> Option<Dn>ImageBuffers in anImage, which for some reason we didn't already have.gaussian_blur, on my 2013 macbook the results are:And on my bigger rig (AMD Ryzen 5950x) its' more like
~380msfor the ST and~160msfor the Rayon version. [on 100 samples]To run the benchmarks on your own machine(s) do a
cargo bench --features='rayon', there are graphs in the./target/criterion/*directory that gets created by this bench harness .I was working on this because I am doing some GPGPU image processing at the moment and prefer to play with space data when playing, but that's another PR for another time.